Fixed issue with unknown extension when using allowArbitraryExtensions compiler option
#313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timocov
requested changes
Apr 14, 2024
There was a problem hiding this comment.
Thanks for your contribution! Please add a test case for this change, see https://github.com/timocov/dts-bundle-generator/tree/master/tests/e2e
|
https://github.com/timocov/dts-bundle-generator/tree/master/tests/e2e/test-cases/allow-js could be a good example of what you'd need to have. |
stepankuzmin
force-pushed
the
skip-unsupported-extensions
branch
from
d63c8c0
to
4ec8de6
Compare
stepankuzmin
force-pushed
the
skip-unsupported-extensions
branch
from
4ec8de6
to
f7d7a72
Compare
|
@stepankuzmin are you sure this fix fixes your problem? I just tried to run your test case against the version without your changes and it just works... Do you have a repro that I can take a look at? |
So we can validate the fix works
|
It seems changing extension of an entry file from |
timocov
approved these changes
Apr 15, 2024
timocov
changed the title
allowArbitraryExtensions compiler option
|
The fix has been published in 9.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip files with unknown extensions. Otherwise,
dts-bundle-generatorwill throw on.d.json.tsfiles because it doesn't support overriding the type of a JSON file.