Reland: For jinja autoescape, mark HTML strings as safe, not needing escaping #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…escaping
(The previous version of this change had a mistake that was inserting Markup in the wrong place.)
For contexts where Jinja's autoescape is enabled, this is necessary for keeping this string working without it being escaped.
(This might become the default behavior in the next version of MkDocs)
If so, the HTML will be pasted like this into the doc:
<span class="git-revision-date-localized-plugin git-revision-date-localized-plugin-date">March 17, 2022</span>
When Jinja's autoescape is not enabled, there's no change in behavior.
|
Will not be necessary, not moving forward with this change in mkdocs for the near future. |
|
Just wanted to say I really appreciate you pushing the mkdocs ecosystem forward, and even taking the effort to contribute downstream to plugins! From my side, it's not a problem to introduce changes that require plugins to upgrade -- if it means we can move mkdocs forward. Thanks for all your effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(The previous version of this change had a mistake that was inserting Markup in the wrong place.)
Original description:
For contexts where Jinja's autoescape is enabled, this is necessary for keeping this string working without it being escaped.
(This might become the default behavior in the next version of MkDocs)
If so, the HTML will be pasted like this into the doc:
When Jinja's autoescape is not enabled, there's no change in behavior.