Drop IE11 support and remove unmaintained depends #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aside from letting us drop the legacy build it also let's us drop the jquery-deparam dependency replacing with built-in urlSearchParams
BryanQuigley
force-pushed
the
legacy
branch
from
4c831f3
to
2470abb
Compare
|
This is a prerequisite for further improvements (or removal) of jquery. Confirmed through recent stats that IE is easily less than .1% (For reference Edge is at 6%) |
timwis
reviewed
Sep 25, 2023
| @@ -1,5 +1,4 @@ | |||
| <!-- general behavior --> | |||
| <script type="module" src="{{ site.baseurl }}/scripts/dist/modern/index.js"></script> | |||
| <script nomodule src="{{ site.baseurl }}/scripts/dist/legacy/index.js"></script> | |||
| <script type="module" src="{{ site.baseurl }}/scripts/dist/index.js"></script> | |||
There was a problem hiding this comment.
The package.json still uses a named target. I would assume that npm run build still outputs the compiled index.js file to the modern directory, doesn't it? If not, feel free to disregard.
There was a problem hiding this comment.
Nope, it doesn't - and this was odd to me as well.
|
Hey Bryan, sorry for the delay. I'm happy with this change in principle - just left one question for you to confirm, then happy for you to merge when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from letting us drop the legacy build it also let's us drop the jquery-deparam dependency replacing with built-in urlSearchParams
Confirmed this seems to work just fine - just not on IE11.