Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustness improvements #278

Merged
merged 1 commit into from Sep 14, 2023
Merged

Robustness improvements #278

merged 1 commit into from Sep 14, 2023

Conversation

BryanQuigley
Copy link
Collaborator

@BryanQuigley BryanQuigley commented Aug 19, 2023

Require yaml parsing for build, builds will fail if yaml
isn't correct.

switch to faster megalinter which should make it easier to do
more future tests

included some yaml prettier changes

Resolves: #276

@BryanQuigley BryanQuigley changed the title Quality improvements Robustness improvements Aug 20, 2023
Require yaml parsing for build, builds will fail if yaml
isn't correct.

switch to faster megalinter which should make it easier to do
more future tests

included some yaml prettier changes

Resolves: #276
@BryanQuigley
Copy link
Collaborator Author

BryanQuigley commented Aug 20, 2023

I had a better version of this megalinter check on I guess a private project, but this still should be much faster to use locally.

@timwis
Copy link
Owner

timwis commented Sep 13, 2023

Hey @BryanQuigley pardon my delay - I've just got back from holiday. This looks fine to me - the only thing we'd want to check is whether the way that DecapCMS saves YAML is compatible with these linting rules, otherwise the build would fail after every update from the CMS. Unless this only checks source code and not the data directories?

@BryanQuigley
Copy link
Collaborator Author

BryanQuigley commented Sep 14, 2023

Thanks for the review! Hope you had a good holiday.

Confirmed the DecapCMS saved yaml works fine. The megalinter yaml check is likely easier to pass then the Jekyll requirements (or it's just formatting)- which if those don't work we don't get a page.

DecapCMS seems to work a bit better locally now - going to see if I can automate that more..

@BryanQuigley BryanQuigley merged commit 1758cab into main Sep 14, 2023
1 check passed
@BryanQuigley BryanQuigley deleted the quality branch September 14, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

strict_front_matter: true important for GitHub flow
2 participants