Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing lib.component.spec.ts failed on JEST test #139

Merged
merged 1 commit into from
Jan 10, 2018

Conversation

sayuthisobri
Copy link
Contributor

I think there are no more innerText field on nativeElement object. Replaced with textContent.

image

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.984% when pulling f4b6bf5 on sayuthisobri:feat-jest into 2ef8d99 on tinesoft:feat-jest.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.984% when pulling f4b6bf5 on sayuthisobri:feat-jest into 2ef8d99 on tinesoft:feat-jest.

@tinesoft
Copy link
Owner

Hi @sayuthisobri

Thanks for your PR!
Indeed, it seems that innerText, which is not standard, is not currently supported by jsdom jsdom/jsdom#1245 used by Jest. Good catch!

@tinesoft tinesoft merged commit 93f4514 into tinesoft:feat-jest Jan 10, 2018
tinesoft added a commit that referenced this pull request Jan 10, 2018
* feat(testing): add support for `jest` testing platform

* chore(test): fix lib.component.spec.ts failed on JEST test (#139)

* chore(test): fix @types/jest error on compiling angular v2 generated project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants