fix: fixed issues with req.url and added more tests
#413
+195
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talentlessguy
requested changes
Oct 8, 2023
talentlessguy
requested changes
Oct 23, 2023
talentlessguy
requested changes
Oct 23, 2023
talentlessguy
requested changes
Oct 24, 2023
talentlessguy
requested changes
Jan 6, 2024
| const handle = (mw: Middleware) => async (req: Req, res: Res, next?: NextFunction) => { | ||
| const { path, handler, regex } = mw | ||
|
|
||
| req.url = reqUrlCopy // reset req.url since it is changed in the handle fn |
There was a problem hiding this comment.
why do we reset req.url here?
There was a problem hiding this comment.
If you have multiple middlewares for 1 path, the req.url is modified as per
tinyhttp/packages/app/src/app.ts
Line 376 in 7bf2953
and hence, every single middleware after the first receives the altered req.url.
There was a problem hiding this comment.
req.url is supposed to be modified. It's different for subapps. that's why req.originalUrl exists
aarontravass
changed the title
req.url and added more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.