Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: migrate to EventEmitterAsyncResource #91

Merged
merged 6 commits into from May 8, 2024
Merged

fix!: migrate to EventEmitterAsyncResource #91

merged 6 commits into from May 8, 2024

Conversation

userquin
Copy link
Contributor

@userquin userquin commented May 2, 2024 •
edited

This PR also includes:

  • update pnpm to 9.0.6
  • update engines to node 18 or >= 20
  • update tsup to 8: now all assets in dist and entry folders (removed esm subfolders)
  • add exports including entry/utils subpackage (only entry point is public)
  • removed unused dependencies

closes #82

userquin
userquin commented May 2, 2024
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
AriPerkkio
AriPerkkio requested changes May 4, 2024
View reviewed changes
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Thanks!

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
test/fixtures/notify-then-sleep.ts Outdated Show resolved Hide resolved
@userquin userquin requested a review from AriPerkkio May 4, 2024 11:20
@userquin
Copy link
Contributor Author

userquin commented May 4, 2024

There are some ts errors in the tests: task-queue.test.ts and uncaught-exception-from-handler.test.ts

@AriPerkkio
Copy link
Member

There are some ts errors in the tests: task-queue.test.ts and uncaught-exception-from-handler.test.ts

Typescript is a bit more strict now. I can fix these after merging this PR as it seems I'm unable to push to your fork. I might be missing some permissions from Tinylibs organization. 🤔

AriPerkkio
AriPerkkio approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and other maintenance related changes! 🙌

I'll be merging and releasing this in a new breaking change release next week.

@AriPerkkio AriPerkkio merged commit 4bd4327 into tinylibs:main May 8, 2024
6 checks passed
@userquin userquin deleted the fix-types branch May 8, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AriPerkkio AriPerkkio AriPerkkio approved these changes

Assignees
No one assigned
Labels
breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installing tinypool causes typescript errors.
2 participants
@userquin @AriPerkkio