Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't focus button on closing toolbar group #8217

Open
wants to merge 2 commits into
base: release/5.10
Choose a base branch
from
Open

Don't focus button on closing toolbar group #8217

wants to merge 2 commits into from

Conversation

bytestream
Copy link

@bytestream bytestream commented Oct 26, 2022 •
edited

Related Ticket:

Steps to replicate:

  1. https://fiddle.tiny.cloud/oqiaab
  2. Click the paragraph format button
  3. Click numbered list
  4. Click inside the editor to focus the numbered list

Actual Result:
Focus is set to the numbered list button in the toolbar

Expected Result:
Focus should be set in the editor

Pre-checks:

  • Changelog entry added
  • Tests have been added (if applicable)
  • Branch prefixed with feature/, hotfix/ or spike/

Review:

  • Milestone set
  • Docs ticket created (if applicable)

GitHub issues (if applicable):

@bytestream bytestream requested a review from mkzhx October 26, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spocke spocke Awaiting requested review from spocke spocke is a code owner

@ltrouton ltrouton Awaiting requested review from ltrouton ltrouton is a code owner

@HAFRMO HAFRMO Awaiting requested review from HAFRMO HAFRMO is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Community PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bytestream @lnewson