Make placeholder and alert dynamic #8360
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 27, 2022 18:06
`anchor_name_placeholder` and `anchor_invalid_message`
in anchor plugin
|
@spocke @TheSpyder @hamza0867 Any thoughts on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! we have been using tinymce for our project and it has been working great. We recently tried out the anchor plugin and wanted to change the default placeholder that is shown
Also, we wanted to improve the default message shown on invalid anchor
Therefore, I created this PR to allow ability to do that.
Related Ticket:
Description of Changes:
Add two new options
anchor_name_placeholder: To change the placeholder textanchor_invalid_message: To change the default alert messagePre-checks:
feature/,hotfix/orspike/Review:
GitHub issues (if applicable):