Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TINY-10890: Render inline math equations as inline-block #9604

Merged
merged 1 commit into from Apr 30, 2024
Merged

TINY-10890: Render inline math equations as inline-block #9604

merged 1 commit into from Apr 30, 2024

Conversation

spocke
Copy link
Member

@spocke spocke commented Apr 30, 2024

Related Ticket: TINY-10890

Description of Changes:

  • Changes the CSS so that inline math equations becomes inline blocks. Should fix two things both the border issue and the selection issue of math elements with display="block" inside a tiny-math-inline.

Pre-checks:

  • [-] Changelog entry added
  • [-] Tests have been added (if applicable)
  • Branch prefixed with feature/, hotfix/ or spike/

Review:

  • Milestone set
  • [-] Docs ticket created (if applicable)

GitHub issues (if applicable):

@spocke spocke added this to the 7.1.0 milestone Apr 30, 2024
@spocke spocke requested review from noxuhax and a team as code owners April 30, 2024 07:49
@spocke spocke requested review from TheSpyder, vpyshnenko, ltrouton, a team, lostkeys, hamza0867 and HAFRMO and removed request for a team April 30, 2024 07:49
@spocke spocke merged commit 0216c02 into release/7 Apr 30, 2024
5 checks passed
@spocke spocke deleted the hotfix/TINY-10890 branch April 30, 2024 10:46
tiny-ben-tran added a commit that referenced this pull request May 9, 2024
@tiny-ben-tran @spocke
TINY-10628: Merge release/7 into main (#9629)
3614abe 
* TINY-10631: Bumped tinymce version number

* TINY-10890: Added inline-block display for tiny-math-inline (#9604)

* Added missing help dialog translations

* Forgot to remove the FullDemo.ts change

* TINY-10629: Minor fixes to changelog entries (#9620)

* TINY-10628: Merge changelog entries (#9626)

---------

Co-authored-by: Spocke <spocke@moxiecode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamza0867 hamza0867 hamza0867 approved these changes

@HAFRMO HAFRMO HAFRMO approved these changes

@noxuhax noxuhax Awaiting requested review from noxuhax noxuhax is a code owner

@TheSpyder TheSpyder Awaiting requested review from TheSpyder TheSpyder is a code owner automatically assigned from tinymce/tinymce-reviewers

@vpyshnenko vpyshnenko Awaiting requested review from vpyshnenko vpyshnenko is a code owner automatically assigned from tinymce/tinymce-reviewers

@ltrouton ltrouton Awaiting requested review from ltrouton ltrouton is a code owner automatically assigned from tinymce/tinymce-reviewers

@lostkeys lostkeys Awaiting requested review from lostkeys lostkeys was automatically assigned from tinymce/high-velocity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spocke @hamza0867 @HAFRMO