New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TINY-10871: replace placeholders with labels #9606

Draft

ztomaszyk wants to merge 1 commit into main from feature/TINY-10871

Contributor

ztomaszyk commented Apr 30, 2024

Related Ticket: https://ephocks.atlassian.net/browse/TINY-10871

Description of Changes:

Placeholder text

Pre-checks:

Changelog entry added
Tests have been added (if applicable)
Branch prefixed with feature/, hotfix/ or spike/

Review:

Milestone set
Docs ticket created (if applicable)

GitHub issues (if applicable):


          TINY-10871: replace placeholders with labels

6f03caf

ztomaszyk requested a review from a team as a code owner

April 30, 2024 12:36

ztomaszyk requested review from spocke, vpyshnenko and ltrouton

April 30, 2024 12:36

Contributor

vpyshnenko commented Apr 30, 2024

Some tests start failing due error
Error: Could not find selector: input.tox-textfield[placeholder="Find"]

spocke marked this pull request as draft

May 2, 2024 11:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

spocke Awaiting requested review from spocke spocke is a code owner automatically assigned from tinymce/tinymce-reviewers

vpyshnenko Awaiting requested review from vpyshnenko vpyshnenko is a code owner automatically assigned from tinymce/tinymce-reviewers

ltrouton Awaiting requested review from ltrouton ltrouton is a code owner automatically assigned from tinymce/tinymce-reviewers

At least 2 approving reviews are required to merge this pull request.