Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TINY-10840: Fixed errors thrown by ForceBlocks and element selections #9621

Merged
merged 9 commits into from May 15, 2024
Merged

TINY-10840: Fixed errors thrown by ForceBlocks and element selections #9621

merged 9 commits into from May 15, 2024

Conversation

spocke
Copy link
Member

@spocke spocke commented May 7, 2024 •
edited

Related Ticket: TINY-10840

Description of Changes:

  • Added a new way to store/restore selections when wrapping elements in the root so that it doesn't throw if the element indexes doesn't match after it's been wrapped.
  • Had to add special code for Firefox that does strange things when the body is empty or filled.

Pre-checks:

  • Changelog entry added
  • Tests have been added (if applicable)
  • Branch prefixed with feature/, hotfix/ or spike/

Review:

  • Milestone set
  • Docs ticket created (if applicable)

GitHub issues (if applicable):

@spocke spocke added this to the 7.2.0 milestone May 7, 2024
@spocke spocke requested a review from a team as a code owner May 7, 2024 09:20
@spocke spocke requested review from TheSpyder, hamza0867, vpyshnenko, a team, lostkeys and HAFRMO and removed request for a team May 7, 2024 09:20
TheSpyder
TheSpyder approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@TheSpyder TheSpyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@spocke spocke merged commit 1b981f0 into main May 15, 2024
3 checks passed
@spocke spocke deleted the feature/TINY-10840 branch May 15, 2024 07:22
@spocke spocke mentioned this pull request May 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSpyder TheSpyder TheSpyder approved these changes

@lorenzo-pomili lorenzo-pomili lorenzo-pomili approved these changes

@hamza0867 hamza0867 Awaiting requested review from hamza0867 hamza0867 is a code owner automatically assigned from tinymce/tinymce-reviewers

@vpyshnenko vpyshnenko Awaiting requested review from vpyshnenko vpyshnenko is a code owner automatically assigned from tinymce/tinymce-reviewers

@lostkeys lostkeys Awaiting requested review from lostkeys lostkeys was automatically assigned from tinymce/high-velocity

@HAFRMO HAFRMO Awaiting requested review from HAFRMO HAFRMO was automatically assigned from tinymce/high-velocity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spocke @TheSpyder @lorenzo-pomili