This repository has been archived by the owner on Nov 18, 2020. It is now read-only.
Add support for jsonValue() in JsonTreeWriter #1
+32
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We don't have CI set up here but it passes in the original PR |
dglinenko
reviewed
Nov 17, 2020
| * @since 2.8.7 | ||
| */ | ||
| @Override public JsonWriter jsonValue(String value) throws IOException { | ||
| put(JsonParser.parseString(value)); |
There was a problem hiding this comment.
I don't have full context here but do we want to check for null value?
I see other methods do
if (value == null) {
return nullValue();
}
|
Scrapping this as we no longer need this fork |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of google#1819