Add a "excludeFile" option #21
Conversation
This option will dynamically add files to the excludedFiles list, allowing proto2 files in the dependencies of a proto3 file as long as its data structures are not used directly.
|
@tiziano88 Do you consider merging this PR? |
|
@tiziano88 Sorry for poking again, but I would like to know if you intend to merge this PR. (btw I suggest you close the PR you do not intend to merge). |
|
I am not particularly enthusiastic about the proposed approach, but I do think we should solve the underlying issue; I think that implementing some basic support for proto2 would actually not be too much more work, and would also be useful for people who for some reason or another are stuck with proto2. WDYT? |
|
The solution is not ideal but it is by far the simplest one solving the issue. Basic support for proto2 could be useful indeed, but only with Bytes encoding as there is no official json mapping for proto2. Also, implementing such a feature should be done if there is actually a clearly identified need: in my case I do not need proto2 message support. My 2 cents ^^ |
Solve the case were a proto2 file is in the dependencies and we cannot remove it (and is a less-invasive solution than #19)
Example:
protoc "--elm_out=excludeFile=google/protobuf/descriptor.proto:."