Refactor classes into files

[shadowspawn]

Pull Request

Problem

The single-file index.js is a bit intimidating to work in, specially for new contributors. We now have some classes which can stand alone.

Issue: #1496

Solution

Short version: factor out the classes into separate files!

Implementation detail: the Help class takes parameter types of multiple classes, but this is a type dependency and not a code dependency. Using a TypeScript style JSDoc import allows the strong typing checks without introducing a circular require dependency between help.js and command.js. I am using Visual Studio Code which understands this for IntelliSense, and TypeScript uses this for npm run typescript-checkJS. If we have other editors people want to use that have their own imports, we can add them as required.

I like that the exports are now simple and obvious in index.tab .

ChangeLog

• refactor index.tab into a file per class

[shadowspawn]

Future reference: if we do need to do "real" imports then @cravler demonstrated how to simply break the cycle by having Command implement createHelp in a superclass in index.tab. Skeleton:

class Command extends BaseCommand {
  createCommand(name) {
    return new Command(name);
  };

  createHelp() {
    return Object.assign(new Help(), this.configureHelp());
  };
}

[shadowspawn]

I moved back to draft, I just want to check can install from a pack and it works before I call it ready. [Done.]

[abetomo]

Great work!