Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support argument processing without action handler #1526

Closed

Conversation

shadowspawn
Copy link
Collaborator

@shadowspawn shadowspawn commented May 22, 2021

Pull Request

Problem

The new processing of arguments is useful in a single command program without an action handler, but
argument defaults and custom processing and choices were only being applied if there was an action handler.

Prompted by .choices() not working without action handler.

Solution

Refactor and process command-arguments whether or not action handler.

When adding the functionality in #1508 I had decided that I preferred not to modify this.args with processed results.
Save processed arguments as this.processedArgs so accessible for simple program without action handler, and from the new hook support too.

@shadowspawn shadowspawn marked this pull request as draft May 22, 2021 02:54
@shadowspawn
Copy link
Collaborator Author

shadowspawn commented May 22, 2021

Ready for review except I don't want to land anything until after #1522, so marking as draft.

(Started working on this on the wrong branch! 🤦 )

@shadowspawn shadowspawn added this to the v8.0.0 milestone May 22, 2021
@shadowspawn
Copy link
Collaborator Author

Redo Pull Request after code refactor. New PR is #1529

@shadowspawn shadowspawn deleted the feature/arguments-without-action branch June 2, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant