Add copyInheritedSettings #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowspawn
added
the
pending release
shadowspawn
removed
the
pending release
|
Released in Commander v8.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
Adding a subcommand using
.command()implicitly copies a bunch of inherited settings from the parent command to the subcommand. There is not currently any public way to transfer inherited settings, say if using.addCommand(), and many are not accessible using public routines or properties.Related: #1186 #1185 (comment)
Solution
Add
.copyInheritedSettings()so available for explicit use, particularly if using `.addCommand()'.Adding for completeness, and not planning to add this to README for now. Has not come up in issues so far.
ChangeLog
.copyInheritedSettings()