Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .requiredOption() for mandatory options #1071

Merged
merged 10 commits into from Oct 8, 2019
Merged

Add .requiredOption() for mandatory options #1071

merged 10 commits into from Oct 8, 2019

Commits on Oct 5, 2019

  1. Add declaration of requiredOption and mandatory property

    @shadowspawn
    shadowspawn committed Oct 5, 2019
    Copy the full SHA
    2376142 View commit details
    Browse the repository at this point in the history

  2. Add initial implementation for error detection for mandatory options

    @shadowspawn
    shadowspawn committed Oct 5, 2019
    Copy the full SHA
    8d59558 View commit details
    Browse the repository at this point in the history

  3. Add unit tests for mandatory options

    @shadowspawn
    shadowspawn committed Oct 5, 2019
    Copy the full SHA
    c9fe359 View commit details
    Browse the repository at this point in the history

  4. Add detailed test for exitOverride intercept for missing mandatory op… 

    …tion
    @shadowspawn
    shadowspawn committed Oct 5, 2019
    Copy the full SHA
    e4aea1b View commit details
    Browse the repository at this point in the history

  5. Add .requiredOption to README

    @shadowspawn
    shadowspawn committed Oct 5, 2019
    Copy the full SHA
    ed13e55 View commit details
    Browse the repository at this point in the history

  6. Reword mandatory description.

    @shadowspawn
    shadowspawn committed Oct 5, 2019
    Copy the full SHA
    1a06de0 View commit details
    Browse the repository at this point in the history

  7. Lookup option value using attributeName, not name

    @shadowspawn
    shadowspawn committed Oct 5, 2019
    Copy the full SHA
    711adc3 View commit details
    Browse the repository at this point in the history

  8. Expand tests 

    - option name different than property name
- both of option/requiredOption for negated option
- add exitOverride to allow Jest to catch unexpected errors
    @shadowspawn
    shadowspawn committed Oct 5, 2019
    Copy the full SHA
    dd61919 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2019

  1. Add .requiredOption calls to TypeScript dummy program

    @shadowspawn
    shadowspawn committed Oct 6, 2019
    Copy the full SHA
    cec1dc6 View commit details
    Browse the repository at this point in the history

  2. Tweak requiredOption example file

    @shadowspawn
    shadowspawn committed Oct 6, 2019
    Copy the full SHA
    41107eb View commit details
    Browse the repository at this point in the history