Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix option type definition to match usage. #1119

Merged
merged 12 commits into from Jan 9, 2020
Merged

fix option type definition to match usage. #1119

merged 12 commits into from Jan 9, 2020

Commits on Dec 12, 2019

  1. fix option type def

    @UrielCh
    UrielCh committed Dec 12, 2019
    Copy the full SHA
    67cc79c View commit details
    Browse the repository at this point in the history

  2. add test 

    improve types
    @UrielCh
    UrielCh committed Dec 12, 2019
    Copy the full SHA
    de995da View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2019

  1. change definition order

    @UrielCh
    UrielCh committed Dec 18, 2019
    Copy the full SHA
    78fa81d View commit details
    Browse the repository at this point in the history

  2. change def order

    @UrielCh
    UrielCh committed Dec 18, 2019
    Copy the full SHA
    5129c97 View commit details
    Browse the repository at this point in the history

  3. fix typing

    @UrielCh
    UrielCh committed Dec 18, 2019
    Copy the full SHA
    cd8fd03 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2019

  1. improve typing enforce current implementation

    @UrielCh
    UrielCh committed Dec 24, 2019
    Copy the full SHA
    5823a8e View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2019

  1. final patch

    @UrielCh
    UrielCh committed Dec 28, 2019
    Copy the full SHA
    c9b5deb View commit details
    Browse the repository at this point in the history

  2. drop all void returning option

    @UrielCh
    UrielCh committed Dec 28, 2019
    Copy the full SHA
    7933511 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2019

  1. fix missing boolean type for default value

    @UrielCh
    UrielCh committed Dec 31, 2019
    Copy the full SHA
    9de970b View commit details
    Browse the repository at this point in the history

  2. clean code

    @UrielCh
    UrielCh committed Dec 31, 2019
    Copy the full SHA
    383afb6 View commit details
    Browse the repository at this point in the history

  3. clean code

    @UrielCh
    UrielCh committed Dec 31, 2019
    Copy the full SHA
    7426210 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2020

  1. Merge branch 'release/5.x' into master

    @UrielCh
    UrielCh committed Jan 6, 2020
    Copy the full SHA
    5893749 View commit details
    Browse the repository at this point in the history