Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createCommand factory routine #1191

Merged
merged 13 commits into from Mar 2, 2020
Merged

createCommand factory routine #1191

merged 13 commits into from Mar 2, 2020

Commits on Feb 14, 2020

  1. Add factory method

    @shadowspawn
    shadowspawn committed Feb 14, 2020
    Copy the full SHA
    b99c4b4 View commit details
    Browse the repository at this point in the history

  2. Fix return doc

    @shadowspawn
    shadowspawn committed Feb 14, 2020
    Copy the full SHA
    57883f5 View commit details
    Browse the repository at this point in the history

  3. Can not use "this" for return type of createCommand

    @shadowspawn
    shadowspawn committed Feb 14, 2020
    Copy the full SHA
    116405b View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2020

  1. Merge branch 'develop' into feature/factory

    @shadowspawn
    shadowspawn committed Feb 22, 2020
    Copy the full SHA
    0918596 View commit details
    Browse the repository at this point in the history

  2. Use return type of createCommand for subcommand

    @shadowspawn
    shadowspawn committed Feb 22, 2020
    Copy the full SHA
    86a8ae5 View commit details
    Browse the repository at this point in the history

  3. Add mention of .command from .createCommand

    @shadowspawn
    shadowspawn committed Feb 22, 2020
    Copy the full SHA
    045b011 View commit details
    Browse the repository at this point in the history

  4. Remove trailing space

    @shadowspawn
    shadowspawn committed Feb 22, 2020
    Copy the full SHA
    af3a2ee View commit details
    Browse the repository at this point in the history

  5. Add examples for createCommand

    @shadowspawn
    shadowspawn committed Feb 22, 2020
    Copy the full SHA
    fa202c4 View commit details
    Browse the repository at this point in the history

  6. Explain example and make a little more realistic

    @shadowspawn
    shadowspawn committed Feb 22, 2020
    Copy the full SHA
    3940a5d View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2020

  1. Add comments pointing from .addCommand to .command 

    One of the downsides of extra ways of adding and creating commands is confusion with the more common way.
    @shadowspawn
    shadowspawn committed Feb 23, 2020
    Copy the full SHA
    052e309 View commit details
    Browse the repository at this point in the history

  2. Add createCommand to README

    @shadowspawn
    shadowspawn committed Feb 23, 2020
    Copy the full SHA
    841740d View commit details
    Browse the repository at this point in the history

  3. Shift command/subcommand contrast

    @shadowspawn
    shadowspawn committed Feb 23, 2020
    Copy the full SHA
    cb44c62 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2020

  1. Use single quotes in ts like in js, and clean up whitespace in new code

    @shadowspawn
    shadowspawn committed Mar 2, 2020
    Copy the full SHA
    18e967c View commit details
    Browse the repository at this point in the history