Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for variadic options #1250

Merged
merged 13 commits into from Jun 1, 2020
Merged

Add support for variadic options #1250

merged 13 commits into from Jun 1, 2020

Commits on Apr 19, 2020

  1. First cut at variadic option implementation

    @shadowspawn
    shadowspawn committed Apr 19, 2020
    Copy the full SHA
    1175518 View commit details
    Browse the repository at this point in the history

  2. Rework variadic regexp 

    - remove ellipsis for symmetry with .arguments
- require word character before dots
    @shadowspawn
    shadowspawn committed Apr 19, 2020
    Copy the full SHA
    c728420 View commit details
    Browse the repository at this point in the history

  3. Add tests for variadic options

    @shadowspawn
    shadowspawn committed Apr 19, 2020
    Copy the full SHA
    bde0e61 View commit details
    Browse the repository at this point in the history

  4. Add test on non-variadic pattern

    @shadowspawn
    shadowspawn committed Apr 19, 2020
    Copy the full SHA
    6eb6a51 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2020

  1. Rethink interation of variadic and coercion function

    @shadowspawn
    shadowspawn committed May 4, 2020
    Copy the full SHA
    8c88da7 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2020

  1. Merge remote-tracking branch 'upstream/release/6.x' into feature/vari… 

    …adic-options
    @shadowspawn
    shadowspawn committed May 30, 2020
    Copy the full SHA
    b52e258 View commit details
    Browse the repository at this point in the history

  2. Fix typos

    @shadowspawn
    shadowspawn committed May 30, 2020
    Copy the full SHA
    a6e51cc View commit details
    Browse the repository at this point in the history

  3. Raise ecmaVersion to eliminate some false positive errors in example … 

    …files
    @shadowspawn
    shadowspawn committed May 30, 2020
    Copy the full SHA
    6bfb43f View commit details
    Browse the repository at this point in the history

  4. Improve variadic option with optional value, zero or more values

    @shadowspawn
    shadowspawn committed May 30, 2020
    Copy the full SHA
    e5ffe3b View commit details
    Browse the repository at this point in the history

  5. Reorder comparison to match previous test

    @shadowspawn
    shadowspawn committed May 30, 2020
    Copy the full SHA
    395f574 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2020

  1. Use consistent test names

    @shadowspawn
    shadowspawn committed May 31, 2020
    Copy the full SHA
    8bcbdab View commit details
    Browse the repository at this point in the history

  2. Add example and README for variadic option

    @shadowspawn
    shadowspawn committed May 31, 2020
    Copy the full SHA
    6c7e8c1 View commit details
    Browse the repository at this point in the history

  3. Fix typo

    @shadowspawn
    shadowspawn committed May 31, 2020
    Copy the full SHA
    9704200 View commit details
    Browse the repository at this point in the history