Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: remove eslint-disable jest/no-test-callback #1312

Merged
merged 3 commits into from Jul 25, 2020
Merged

tests: remove eslint-disable jest/no-test-callback #1312

merged 3 commits into from Jul 25, 2020

Commits on Jul 25, 2020

  1. tests: remove eslint-disable jest/no-test-callback 

    Instead of using the `done` callback from the test function, we can be using a Promise instead.
I've checked that if `resolve` is not called the test fails (timeout).
    @michga
    michga committed Jul 25, 2020
    Copy the full SHA
    018060d View commit details
    Browse the repository at this point in the history

  2. fix: code style

    @michga
    michga committed Jul 25, 2020
    Copy the full SHA
    d750982 View commit details
    Browse the repository at this point in the history

  3. test: ensure an assertion is made (code review)

    @michga
    michga committed Jul 25, 2020
    Copy the full SHA
    dfbbc0a View commit details
    Browse the repository at this point in the history