Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Option class to allow hiding help, specifying choices, and change how default value displayed in help #1331

Merged
merged 45 commits into from Sep 14, 2020
Merged

Enhance Option class to allow hiding help, specifying choices, and change how default value displayed in help #1331

merged 45 commits into from Sep 14, 2020

Commits on Aug 15, 2020

  1. Add .addOption and use as bottleneck. Make all Option properties priv… 

    …ate.
    @shadowspawn
    shadowspawn committed Aug 15, 2020
    Copy the full SHA
    5a8c010 View commit details
    Browse the repository at this point in the history

  2. Desription for object is optional

    @shadowspawn
    shadowspawn committed Aug 15, 2020
    Copy the full SHA
    ac590a6 View commit details
    Browse the repository at this point in the history

  3. Add support for hidden options

    @shadowspawn
    shadowspawn committed Aug 15, 2020
    Copy the full SHA
    77c8409 View commit details
    Browse the repository at this point in the history

  4. Try setFoo for booleans so less ambiguous what no parameter means

    @shadowspawn
    shadowspawn committed Aug 15, 2020
    Copy the full SHA
    69d084d View commit details
    Browse the repository at this point in the history

  5. Renamed method

    @shadowspawn
    shadowspawn committed Aug 15, 2020
    Copy the full SHA
    c1665e1 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2020

  1. Restore Option property names to reduce churn

    @shadowspawn
    shadowspawn committed Aug 16, 2020
    Copy the full SHA
    6da28cc View commit details
    Browse the repository at this point in the history

  2. Try more fluent names for non-property methods

    @shadowspawn
    shadowspawn committed Aug 16, 2020
    Copy the full SHA
    fcd73c7 View commit details
    Browse the repository at this point in the history

  3. Avoid renaming existing members of Option

    @shadowspawn
    shadowspawn committed Aug 16, 2020
    Copy the full SHA
    fcc3d80 View commit details
    Browse the repository at this point in the history

  4. Add default description for help

    @shadowspawn
    shadowspawn committed Aug 16, 2020
    Copy the full SHA
    fb486f7 View commit details
    Browse the repository at this point in the history

  5. Fix return JSDoc

    @shadowspawn
    shadowspawn committed Aug 16, 2020
    Copy the full SHA
    f266bb7 View commit details
    Browse the repository at this point in the history

  6. First cut at choices

    @shadowspawn
    shadowspawn committed Aug 16, 2020
    Copy the full SHA
    d8a2f85 View commit details
    Browse the repository at this point in the history

  7. Throw CommanderError for easier detection

    @shadowspawn
    shadowspawn committed Aug 16, 2020
    Copy the full SHA
    9fa7ebf View commit details
    Browse the repository at this point in the history

  8. Add catch for tidy coercion failure handing

    @shadowspawn
    shadowspawn committed Aug 16, 2020
    Copy the full SHA
    5103430 View commit details
    Browse the repository at this point in the history

  9. Add tests for Option.choices

    @shadowspawn
    shadowspawn committed Aug 16, 2020
    Copy the full SHA
    fe3d543 View commit details
    Browse the repository at this point in the history

  10. Rename custom option processing property

    @shadowspawn
    shadowspawn committed Aug 16, 2020
    Copy the full SHA
    8e7804c View commit details
    Browse the repository at this point in the history

  11. Add run script for TypeScript checkJS

    @shadowspawn
    shadowspawn committed Aug 16, 2020
    Copy the full SHA
    0a513cf View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2020

  1. Add tests for chaining routines

    @shadowspawn
    shadowspawn committed Aug 17, 2020
    Copy the full SHA
    8ccebe4 View commit details
    Browse the repository at this point in the history

  2. More consistent name for custom option arg processing

    @shadowspawn
    shadowspawn committed Aug 17, 2020
    Copy the full SHA
    408501b View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2020

  1. Add choices to help

    @shadowspawn
    shadowspawn committed Aug 18, 2020
    Copy the full SHA
    12e81c2 View commit details
    Browse the repository at this point in the history

  2. .default() now expects parameter

    @shadowspawn
    shadowspawn committed Aug 18, 2020
    Copy the full SHA
    e3d997d View commit details
    Browse the repository at this point in the history

  3. Fixed return type

    @shadowspawn
    shadowspawn committed Aug 18, 2020
    Copy the full SHA
    312321d View commit details
    Browse the repository at this point in the history

  4. Separate out argumentRejected for possible reuse

    @shadowspawn
    shadowspawn committed Aug 18, 2020
    Copy the full SHA
    d541cee View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2020

  1. Add back support for RegExp which accidentally dropped.

    @shadowspawn
    shadowspawn committed Aug 20, 2020
    Copy the full SHA
    c916a17 View commit details
    Browse the repository at this point in the history

  2. Add test for obsolete regexp

    @shadowspawn
    shadowspawn committed Aug 20, 2020
    Copy the full SHA
    9f92db7 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2020

  1. Add TypeScript definitions for new Option properties

    @shadowspawn
    shadowspawn committed Aug 23, 2020
    Copy the full SHA
    b8c5ecc View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2020

  1. Switch from obsolete to deprecated, clearer meaning

    @shadowspawn
    shadowspawn committed Aug 24, 2020
    Copy the full SHA
    d7f0998 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Fix left-over edit

    @shadowspawn
    shadowspawn committed Sep 4, 2020
    Copy the full SHA
    3a32314 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2020

  1. Add comment

    @shadowspawn
    shadowspawn committed Sep 5, 2020
    Copy the full SHA
    91df291 View commit details
    Browse the repository at this point in the history

  2. Simplify the comments

    @shadowspawn
    shadowspawn committed Sep 5, 2020
    Copy the full SHA
    5205053 View commit details
    Browse the repository at this point in the history

  3. Add README and example file

    @shadowspawn
    shadowspawn committed Sep 5, 2020
    Copy the full SHA
    eb12b74 View commit details
    Browse the repository at this point in the history

  4. Remove example covered elsewhere

    @shadowspawn
    shadowspawn committed Sep 5, 2020
    Copy the full SHA
    35e854a View commit details
    Browse the repository at this point in the history

  5. Restore example, leave change for a separate PR

    @shadowspawn
    shadowspawn committed Sep 5, 2020
    Copy the full SHA
    9e143e6 View commit details
    Browse the repository at this point in the history

  6. Fix example output to match changed code

    @shadowspawn
    shadowspawn committed Sep 5, 2020
    Copy the full SHA
    0c3d916 View commit details
    Browse the repository at this point in the history

  7. Add language to code blocks

    @shadowspawn
    shadowspawn committed Sep 5, 2020
    Copy the full SHA
    6966e71 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2020

  1. Rename getFullDescription, not using get much

    @shadowspawn
    shadowspawn committed Sep 6, 2020
    Copy the full SHA
    c79f904 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. Merge branch 'release/7.x' into feature/fluent-options

    @shadowspawn
    shadowspawn committed Sep 9, 2020
    Copy the full SHA
    99da3cb View commit details
    Browse the repository at this point in the history

  2. Add chaining test for addHelpText

    @shadowspawn
    shadowspawn committed Sep 9, 2020
    Copy the full SHA
    8401ee6 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2020

  1. Describe as legacy rather than deprecated in comments, add @deprecated … 

    …for editor feedback to discourage use
    @shadowspawn
    shadowspawn committed Sep 12, 2020
    Copy the full SHA
    c36e08e View commit details
    Browse the repository at this point in the history

  2. Do not have to have both should and long flags these days

    @shadowspawn
    shadowspawn committed Sep 12, 2020
    Copy the full SHA
    88a84f8 View commit details
    Browse the repository at this point in the history

  3. Eliminate duplicate code using internal knowledge

    @shadowspawn
    shadowspawn committed Sep 12, 2020
    Copy the full SHA
    fa09345 View commit details
    Browse the repository at this point in the history

  4. Rename parseArgWith to argParser

    @shadowspawn
    shadowspawn committed Sep 12, 2020
    Copy the full SHA
    f96b36d View commit details
    Browse the repository at this point in the history

  5. Improve JSDoc for help

    @shadowspawn
    shadowspawn committed Sep 12, 2020
    Copy the full SHA
    7a75f3d View commit details
    Browse the repository at this point in the history

  6. Make code and declarations consistent to pass tsc checks

    @shadowspawn
    shadowspawn committed Sep 12, 2020
    Copy the full SHA
    5e4ed3d View commit details
    Browse the repository at this point in the history

  7. Match up write signature to fix linting error

    @shadowspawn
    shadowspawn committed Sep 12, 2020
    Copy the full SHA
    dd5807a View commit details
    Browse the repository at this point in the history

  8. Restore "deprecated", it is the right word

    @shadowspawn
    shadowspawn committed Sep 12, 2020
    Copy the full SHA
    34c7289 View commit details
    Browse the repository at this point in the history