Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More consistent way of adding command arguments #1490

Merged
merged 36 commits into from Apr 8, 2021
Merged

More consistent way of adding command arguments #1490

merged 36 commits into from Apr 8, 2021

Commits on Feb 6, 2021

  1. added addArguments method

    @Niryo
    Niryo committed Feb 6, 2021
    Copy the full SHA
    39a47ed View commit details
    Browse the repository at this point in the history

  2. fix undefined args

    @Niryo
    Niryo committed Feb 6, 2021
    Copy the full SHA
    88a4cc5 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2021

  1. added tests, docs and typings

    @Niryo
    Niryo committed Feb 13, 2021
    Copy the full SHA
    e8415ed View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. code review fixes

    @Niryo
    Niryo committed Feb 19, 2021
    Copy the full SHA
    782f705 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2021

  1. throw error on bad arg

    @Niryo
    Niryo committed Mar 6, 2021
    Copy the full SHA
    d106ca0 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2021

  1. Parse command-argument details in constructor

    @shadowspawn
    shadowspawn committed Mar 13, 2021
    Copy the full SHA
    39cb757 View commit details
    Browse the repository at this point in the history

  2. Handle argument descriptions separately for legacy and new support

    @shadowspawn
    shadowspawn committed Mar 13, 2021
    Copy the full SHA
    8c4d8d0 View commit details
    Browse the repository at this point in the history

  3. Add text to distinguish test names with .each

    @shadowspawn
    shadowspawn committed Mar 13, 2021
    Copy the full SHA
    c2e0a5a View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2021

  1. Match nameAndArgs into two parts, rather than split on spaces.

    @shadowspawn
    shadowspawn committed Mar 14, 2021
    Copy the full SHA
    32f001b View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from shadowspawn/Niryo-addArgument

    @Niryo
    Niryo committed Mar 14, 2021
    Copy the full SHA
    4a8e323 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2021

  1. Update release date post-release to be more accurate

    @shadowspawn
    shadowspawn committed Mar 22, 2021
    1
    Copy the full SHA
    ad20e0b View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2021

  1. Merge pull request #1467 from Niryo/addArgument 

    added addArguments method
    @shadowspawn
    shadowspawn committed Mar 27, 2021
    Copy the full SHA
    9a77be4 View commit details
    Browse the repository at this point in the history

  2. Fix test naming

    @shadowspawn
    shadowspawn committed Mar 27, 2021
    Copy the full SHA
    da37436 View commit details
    Browse the repository at this point in the history

  3. Simplify and tidy argument example

    @shadowspawn
    shadowspawn committed Mar 27, 2021
    Copy the full SHA
    81248e2 View commit details
    Browse the repository at this point in the history

  4. Typing and typings test for .argument

    @shadowspawn
    shadowspawn committed Mar 27, 2021
    Copy the full SHA
    6052c14 View commit details
    Browse the repository at this point in the history

  5. Expand argument section to include existing multiple-argument approac… 

    …hes.
    @shadowspawn
    shadowspawn committed Mar 27, 2021
    Copy the full SHA
    0dd3547 View commit details
    Browse the repository at this point in the history

  6. Add name method and improve Argument typings and tests

    @shadowspawn
    shadowspawn committed Mar 27, 2021
    Copy the full SHA
    0c43cd9 View commit details
    Browse the repository at this point in the history

  7. Fix copy-and-paste JSDoc error

    @shadowspawn
    shadowspawn committed Mar 27, 2021
    Copy the full SHA
    0dea8ac View commit details
    Browse the repository at this point in the history

  8. Update example to match new method and README

    @shadowspawn
    shadowspawn committed Mar 27, 2021
    Copy the full SHA
    82ff5bd View commit details
    Browse the repository at this point in the history

  9. Deprecate old way of adding command argument descriptions

    @shadowspawn
    shadowspawn committed Mar 27, 2021
    Copy the full SHA
    a20a8fe View commit details
    Browse the repository at this point in the history

  10. Be lenient about Argument construction to allow lazy building

    @shadowspawn
    shadowspawn committed Mar 27, 2021
    Copy the full SHA
    df73a19 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2021

  1. Call first param to .argument "name", and expand jsdoc

    @shadowspawn
    shadowspawn committed Mar 28, 2021
    Copy the full SHA
    43ce351 View commit details
    Browse the repository at this point in the history

  2. Add low-level check that get same Argument from multiple ways of spec… 

    …ifying argument
    @shadowspawn
    shadowspawn committed Mar 28, 2021
    Copy the full SHA
    af08a2b View commit details
    Browse the repository at this point in the history

  3. Minor wording tweaks

    @shadowspawn
    shadowspawn committed Mar 28, 2021
    Copy the full SHA
    bac5ea9 View commit details
    Browse the repository at this point in the history

  4. Add low-level tests for multiple arg variations

    @shadowspawn
    shadowspawn committed Mar 28, 2021
    Copy the full SHA
    0e505be View commit details
    Browse the repository at this point in the history

  5. Simplify test. Use .argument now.

    @shadowspawn
    shadowspawn committed Mar 28, 2021
    Copy the full SHA
    dac9656 View commit details
    Browse the repository at this point in the history

  6. Restore simple test, use .argument

    @shadowspawn
    shadowspawn committed Mar 28, 2021
    Copy the full SHA
    3745659 View commit details
    Browse the repository at this point in the history

  7. Big switch from .arguments to .argument in tests

    @shadowspawn
    shadowspawn committed Mar 28, 2021
    Copy the full SHA
    a76f831 View commit details
    Browse the repository at this point in the history

  8. Expand help to explain argument variations

    @shadowspawn
    shadowspawn committed Mar 28, 2021
    Copy the full SHA
    5a08571 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2021

  1. Keep Argument properties private for now (like Command, unlike Option)

    @shadowspawn
    shadowspawn committed Mar 29, 2021
    Copy the full SHA
    747d6ef View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Argument should follow Option for properties, make public again

    @shadowspawn
    shadowspawn committed Mar 30, 2021
    Copy the full SHA
    b7def8a View commit details
    Browse the repository at this point in the history

  2. Generate help for arguments using same methods as for option and subc… 

    …ommand
    @shadowspawn
    shadowspawn committed Mar 30, 2021
    Copy the full SHA
    f54d1ed View commit details
    Browse the repository at this point in the history

  3. Simplify Argument .name(), just getter

    @shadowspawn
    shadowspawn committed Mar 30, 2021
    Copy the full SHA
    0879a1f View commit details
    Browse the repository at this point in the history

  4. Expand test coverage for visibleArguments

    @shadowspawn
    shadowspawn committed Mar 30, 2021
    Copy the full SHA
    1e66821 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2021

  1. Rework the multiple ways of specifying command-arguments

    @shadowspawn
    shadowspawn committed Apr 5, 2021
    Copy the full SHA
    ed7a1c8 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. Add Argument to esm exports (and createOption)

    @shadowspawn
    shadowspawn committed Apr 7, 2021
    Copy the full SHA
    819616f View commit details
    Browse the repository at this point in the history