Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow readonly array as parameter of .choices() #1667

Merged
merged 5 commits into from Jan 4, 2022
Merged

Allow readonly array as parameter of .choices() #1667

merged 5 commits into from Jan 4, 2022

Commits on Dec 30, 2021

  1. Allow readonly array as parameter of .choices() 

    Without `readonly`, readonly arrays cannot be passed as parameters.

Example: https://www.typescriptlang.org/play?#code/GYVwdgxgLglg9mABMAjACgIYCcsC5EDOUWMYA5gNoC6AlIgN4C+AUKJLAsgEyY75YBTDABMEAGwCehYqUq0GLZhARFE2LCkQBeRBQDkGPVQDcSlVDU4u23QaNqCiZWCKnW6dShqngPT9-deLC4A3yCQ4yA
    @ouuan
    ouuan committed Dec 30, 2021
    Copy the full SHA
    e48b469 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2021

  1. Add tests for .choices() typings

    @ouuan
    ouuan committed Dec 31, 2021
    Copy the full SHA
    780cc35 View commit details
    Browse the repository at this point in the history

  2. Take a defensive copy of .choices argument to make sure it's readonly

    @ouuan
    ouuan committed Dec 31, 2021
    Copy the full SHA
    42e938d View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2022

  1. Expand choices tests to cover readonly contract (#1)

    @shadowspawn
    shadowspawn committed Jan 1, 2022
    Copy the full SHA
    4ef9a43 View commit details
    Browse the repository at this point in the history

  2. Use the defensive copy of the parameter of .choices() in parseArg

    @ouuan
    ouuan committed Jan 1, 2022
    Copy the full SHA
    1ee9790 View commit details
    Browse the repository at this point in the history