Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Command.options property #1784

Closed
wants to merge 4 commits into from
Closed

Expose Command.options property #1784

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cab9817
expose options as readonly
mshima Aug 29, 2022
5fa0eaf
export options as plain array
mshima Sep 2, 2022
f486095
Update index.d.ts
mshima Sep 8, 2022
010d151
Update index.test-d.ts
mshima Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions typings/index.d.ts
View file
Open in desktop
Expand Up @@ -277,6 +277,7 @@ export class Command {
processedArgs: any[];
commands: Command[];
parent: Command | null;
readonly options: Option[];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you still want to add options, I would like it after commands (one line higher) and without the readonly.


constructor(name?: string);

Expand Down
1 change: 1 addition & 0 deletions typings/index.test-d.ts
View file
Open in desktop
Expand Up @@ -30,6 +30,7 @@ expectType<string[]>(program.args);
expectType<any[]>(program.processedArgs);
expectType<commander.Command[]>(program.commands);
expectType<commander.Command | null>(program.parent);
expectType<commander.Option[]>(program.options);

// version
expectType<commander.Command>(program.version('1.2.3'));
Expand Down