Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused property #1844

Merged
merged 1 commit into from Jan 22, 2023

Conversation

shadowspawn
Copy link
Collaborator

Pull Request

Problem

The TypeScript definition for option includes optionFlags, but that is not defined in the JavaScript.

Added but not used in #1331

Solution

Delete optionFlags definition.

ChangeLog

  • Fixed: Remove unused Option.optionFlags property from TypeScript defintiion

Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Jan 22, 2023
@shadowspawn shadowspawn merged commit 869c3c0 into tj:develop Jan 22, 2023
@shadowspawn shadowspawn deleted the feature/remove-optionFlags branch January 22, 2023 00:38
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Apr 15, 2023
@shadowspawn
Copy link
Collaborator Author

Shipped in 10.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants