Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add async custom processing support. Add chainArgParserCalls() for configuration. Additionally await thenable implicit and default option values and thenable default argument values #1915

Closed
wants to merge 31 commits into from
Closed

Add async custom processing support. Add chainArgParserCalls() for configuration. Additionally await thenable implicit and default option values and thenable default argument values #1915

wants to merge 31 commits into from

Commits on Jul 25, 2023

  1. Add thenable function 

    Co-authored-by: John Gee <john@ruru.gen.nz>
    @aweebit @shadowspawn
    aweebit and shadowspawn committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    2c6bcf4 View commit details
    Browse the repository at this point in the history

  2. Chain parseArg calls when parseAsync() is called 

    The behavior can be configured via chainArgParserCalls()
    @aweebit
    aweebit committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    9f292ad View commit details
    Browse the repository at this point in the history

  3. Improve JSDoc readability for chainArgParserCalls

    @aweebit
    aweebit committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    d1ac0cd View commit details
    Browse the repository at this point in the history

  4. Await thenable option and argument values when parseAsync() is called 

    The behavior can be configured via await()

Co-authored-by: John Gee <john@ruru.gen.nz>
    @aweebit @shadowspawn
    aweebit and shadowspawn committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    2e7ccd1 View commit details
    Browse the repository at this point in the history

  5. Leave argument variations test untouched 

    Possible since undefined properties are not checked
    @aweebit
    aweebit committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    2d0c78f View commit details
    Browse the repository at this point in the history

  6. Remove redundant checkForUnknownOptions() call 

    Co-authored-by: John Gee <john@ruru.gen.nz>
    @aweebit @shadowspawn
    aweebit and shadowspawn committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    905dac0 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Rework _parseArg()

    @aweebit
    aweebit committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    dacdde0 View commit details
    Browse the repository at this point in the history

  2. Simplify overwritten option value handling

    @aweebit
    aweebit committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    b64f298 View commit details
    Browse the repository at this point in the history

  3. Handle thenable errors not only when chaining but only when awaiting

    @aweebit
    aweebit committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    254865c View commit details
    Browse the repository at this point in the history

  4. Precompute _shouldAwait to avoid repeating costly computation

    @aweebit
    aweebit committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    e66eda5 View commit details
    Browse the repository at this point in the history

  5. Position _parseArg() better

    @aweebit
    aweebit committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    fb48134 View commit details
    Browse the repository at this point in the history

  6. Inherit _asyncParsing. Do not unset it and _shouldAwait 

    This is in accordance with how other properties containing information
about the last parse call such as args & processedArgs do not get unset.
Consistency in how repeated parse calls are handled could be improved by
resolving tj#1916.
    @aweebit
    aweebit committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    c34a839 View commit details
    Browse the repository at this point in the history

  7. Simplify _shouldAwait computation

    @aweebit
    aweebit committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    4d65c6c View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Inherit await behavior the commander way

    @aweebit
    aweebit committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    679bcb5 View commit details
    Browse the repository at this point in the history

  2. Handle overwritten not chained options correctly

    @aweebit
    aweebit committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    ade5f95 View commit details
    Browse the repository at this point in the history

  3. Aggressively prevent unhandled rejections due to overwritten options

    @aweebit
    aweebit committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    d5799cb View commit details
    Browse the repository at this point in the history

  4. Fix linting errors

    @aweebit
    aweebit committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    f5a0557 View commit details
    Browse the repository at this point in the history

  5. Forbid parse() usage with async calls 

    Better than having to deal with unhandled rejections.
    @aweebit
    aweebit committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    ea25170 View commit details
    Browse the repository at this point in the history

  6. Remove await configuration and unnecessary chain mode 

    The simplification is possible now since async calls are forbidden in
parse().
    @aweebit
    aweebit committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    b9643bc View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Warn about incorrect parse() instead of throwing

    @aweebit
    aweebit committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    385fe48 View commit details
    Browse the repository at this point in the history

  2. Separation of concerns: add callback to _parseArg()

    @aweebit
    aweebit committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    d9dcc57 View commit details
    Browse the repository at this point in the history

  3. Position awaiting methods better

    @aweebit
    aweebit committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    3e0e305 View commit details
    Browse the repository at this point in the history

  4. Update life cycle description

    @aweebit
    aweebit committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    608d91c View commit details
    Browse the repository at this point in the history

  5. Update life cycle description: clarify and better match source code

    @aweebit
    aweebit committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    249a0c6 View commit details
    Browse the repository at this point in the history

  6. Adhere to established dot usage pattern

    @aweebit
    aweebit committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    bf7e096 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. Place async argParser warning better

    @aweebit
    aweebit committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    6858bdf View commit details
    Browse the repository at this point in the history

  2. Add thenable default option value warning

    @aweebit
    aweebit committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    1cf9fed View commit details
    Browse the repository at this point in the history

  3. Unify & place thenable option value warnings better

    @aweebit
    aweebit committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    aa6f7c9 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2023

  1. Fix linting error

    @aweebit
    aweebit committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    9d6cee0 View commit details
    Browse the repository at this point in the history

  2. Add missing thenable argument value warnings

    @aweebit
    aweebit committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    2d21112 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Remove NODE_ENV check 

    Motivation: tj#1955
    @aweebit
    aweebit committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    cb8c30b View commit details
    Browse the repository at this point in the history