Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for implicitly constructed commands' setting inheritance #1925

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

aweebit
Copy link
Contributor

@aweebit aweebit commented Aug 1, 2023

Partially fixes #1916.

Cherry-picked from #1917 because the docs extension discussion is already finalized and the change is independent from the other changes introduced there, so it can be merged even now.

ChangeLog

Added

  • documentation for implicitly constructed commands' setting inheritance

@aweebit aweebit changed the base branch from release/12.x to develop August 1, 2023 11:32
(cherry picked from commit dfe2fc7)

Co-authored-by: John Gee <john@ruru.gen.nz>
@aweebit aweebit force-pushed the feature/docs-implicit-inheritance branch from 198c31e to 36b06c1 Compare August 1, 2023 11:34
@aweebit
Copy link
Contributor Author

aweebit commented Aug 1, 2023

(Force push is due to a commit amendment changing the commit message so that the Co-authored-by trailer is placed correctly.)

Copy link
Collaborator

@shadowspawn shadowspawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have wondered about adding something informative but concise about inherited settings for a long time. 👍

aweebit added a commit to aweebit/commander.js that referenced this pull request Aug 4, 2023
Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@abetomo abetomo merged commit 880b028 into tj:develop Aug 8, 2023
11 checks passed
@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Aug 8, 2023
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants