Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about obscured help option #1931

Closed
wants to merge 21 commits into from
Closed

Warn about obscured help option #1931

wants to merge 21 commits into from

Commits on Aug 2, 2023

  1. Support custom flags from Option subclass in helpOption()

    @aweebit
    aweebit committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    1bb30d7 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Fix version() parameter type 

    Borrowed from a3f0e28 that was supposed to land in the now-closed tj#1921.
    @aweebit
    aweebit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    e8bea4a View commit details
    Browse the repository at this point in the history

  2. Change initial variable values in test for better error messages 

    (cherry picked from commit 87db4ba)
    @aweebit
    aweebit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    e4d00db View commit details
    Browse the repository at this point in the history

  3. Warn about obscured help option

    @aweebit
    aweebit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    d03566b View commit details
    Browse the repository at this point in the history

  4. Store help option instance instead of just flags 

    Analogous to 3c94dfd in tj#1933 for version option.

Storing the Option instance of the help option instead of just its
flags (_helpShortFlag, _helpLongFlag) is meaningful for cases when other
properties of the instance need to be accessed (not currently the case,
but could be in the future).
    @aweebit
    aweebit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    9857b1e View commit details
    Browse the repository at this point in the history

  5. Merge branch 'feature/createOption-in-helpOption' into feature/obscur… 

    …ed-help-option-warnings
    @aweebit
    aweebit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    371751e View commit details
    Browse the repository at this point in the history

  6. Warn about help option obscured by version option 

    _registerOption() has been borrowed from deb3bdf in tj#1923.
Watch out for merge conflicts!
    @aweebit
    aweebit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    eacaee8 View commit details
    Browse the repository at this point in the history

  7. Add missing _hasHelpOption check in copyInheritedSettings test

    @aweebit
    aweebit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    da1e153 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'feature/createOption-in-helpOption' into feature/obscur… 

    …ed-help-option-warnings
    @aweebit
    aweebit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    0e5a621 View commit details
    Browse the repository at this point in the history

  9. Do not use undefined long help option flag in legacy code

    @aweebit
    aweebit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    35e9571 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'feature/fixes' into feature/createOption-in-helpOption

    @aweebit
    aweebit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    5128d5f View commit details
    Browse the repository at this point in the history

  11. Merge branch 'feature/createOption-in-helpOption' into feature/obscur… 

    …ed-help-option-warnings
    @aweebit
    aweebit committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    d03ef92 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Check for undefined in Option.is() 

    Eliminates the need for the check in other places.

(cherry picked from commit a12f5be)
    @aweebit
    aweebit committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    97f3069 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/createOption-in-helpOption' into feature/obscur… 

    …ed-help-option-warnings
    @aweebit
    aweebit committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    b6ef1e1 View commit details
    Browse the repository at this point in the history

  3. Add missing obscured help flag tests

    @aweebit
    aweebit committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    7335a9c View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Remove NODE_ENV check 

    Motivation: tj#1955
    @aweebit
    aweebit committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    d0d2c5e View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. Merge branch 'feature/createOption-in-helpOption' into feature/obscur… 

    …ed-help-option-warnings
    @aweebit
    aweebit committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    daa3fed View commit details
    Browse the repository at this point in the history

  2. Revert "Fix version() parameter type" 

    This reverts commit e8bea4a.
    @aweebit
    aweebit committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    a253ec6 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2023

  1. Fix help for commands with executable handler & only a short help flag

    @aweebit
    aweebit committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    8dd417f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/fixes' into feature/createOption-in-helpOption

    @aweebit
    aweebit committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    513a4b5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature/createOption-in-helpOption' into feature/obscur… 

    …ed-help-option-warnings
    @aweebit
    aweebit committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    aa6e9b3 View commit details
    Browse the repository at this point in the history