Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing check for broken passThrough #1937

Merged
merged 6 commits into from
Aug 5, 2023
Merged

Add missing check for broken passThrough #1937

merged 6 commits into from
Aug 5, 2023

Commits on Aug 4, 2023

  1. Add missing checks for passThroughOptions

    @aweebit
    aweebit committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    4f5ab2d View commit details
    Browse the repository at this point in the history

  2. Add tests for illegal passThroughOptions

    @aweebit
    aweebit committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    0ac6609 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2023

  1. Remove illegal passThroughOptions check deemed unnecessary

    @aweebit
    aweebit committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    9d4c96a View commit details
    Browse the repository at this point in the history

  2. Use weaker wording: "broken" instead of "illegal"

    @aweebit
    aweebit committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    43d9faa View commit details
    Browse the repository at this point in the history

  3. Unclutter error message in broken passThrough checks 

    Co-authored-by: John Gee <john@ruru.gen.nz>
    @aweebit @shadowspawn
    aweebit and shadowspawn committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    43cc821 View commit details
    Browse the repository at this point in the history

  4. Refactor _checkForBrokenPassThrough() to make it instance-aware

    @aweebit
    aweebit committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    7689506 View commit details
    Browse the repository at this point in the history