Fix option value source type #1963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowspawn
added
the
on hold
This was referenced Aug 13, 2023
Closed
|
This isn't quite right, and ultimately I want to bring in the changes first tried in commander-js/extra-typings#3 |
shadowspawn
removed
the
on hold
Okay, but #1967 won't work without the problem with this type being solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change has been manually cherry-picked from #1919 so that it can be discussed independently.
Problem
#1919 (comment)
#1919 (comment)
#1919 (comment)
Solution
Compared with the original solution from #1919 (see 7fd0b22...52d5885), the one suggested here keeps
OptionValueSourceas an exported type (could be used in subclasses to narrow down the allowed custom sources) and uses theOptionValueSource | stringunion instead of juststringfor additional clarity.ChangeLog
Fixed
undefinedand arbitrary custom source strings are allowed now)Peer PRs
Changes are to be merged into…
parse()/parseAsync()#1919