-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for exit codes. #436
Conversation
Broken tests, can you fix those up? |
@SomeKittens I'm not sure whether we need that |
Also that would be break change to change default code from 1 to 64. |
Sorry, thought I had gotten all of the tests fixed up. I think there's a legitimate discussion to be had about what exit code to use when the user asks for help with |
Oh, and I'm also happy to change the defaults so that the interface doesn't change, and only the people that want 64-exits get them. |
@hildjj Thank you! I'm not sure I am open to allow user set custom exit code. |
@zhiyelee good checking - I'm ok with user-set as well. |
@zhiyelee is it still necessary? |
I have added this pull request to a triage collection of exit related issues for future reference. This pull request has not had any activity in over six months. It isn't likely to get acted on due to this report. Feel free to open a new issue if it comes up again, with new information and renewed interest. Thank you for your contributions. |
Fixes #435.
Fixes #188.