Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for exit codes. #436

Closed
wants to merge 2 commits into from
Closed

Add support for exit codes. #436

wants to merge 2 commits into from

Conversation

hildjj
Copy link

@hildjj hildjj commented Sep 15, 2015

Fixes #435.
Fixes #188.

@SomeKittens
Copy link
Collaborator

Broken tests, can you fix those up?

@zhiyelee
Copy link
Collaborator

@SomeKittens I'm not sure whether we need that

@zhiyelee
Copy link
Collaborator

Also that would be break change to change default code from 1 to 64.

@hildjj
Copy link
Author

hildjj commented Sep 19, 2015

Sorry, thought I had gotten all of the tests fixed up. I think there's a legitimate discussion to be had about what exit code to use when the user asks for help with --help vs. when they supply invalid arguments. I would be fine with --help returning 0, if you prefer.

@hildjj
Copy link
Author

hildjj commented Sep 19, 2015

Oh, and I'm also happy to change the defaults so that the interface doesn't change, and only the people that want 64-exits get them.

@zhiyelee
Copy link
Collaborator

@hildjj Thank you! I'm not sure 64 is convention for such error. I have checked wget and git with unknown option, they give 2 and 129 respectively.

I am open to allow user set custom exit code.

@SomeKittens
Copy link
Collaborator

@zhiyelee good checking - I'm ok with user-set as well.

@roman-vanesyan
Copy link
Collaborator

@zhiyelee is it still necessary?

@shadowspawn shadowspawn mentioned this pull request Apr 1, 2019
@shadowspawn
Copy link
Collaborator

shadowspawn commented Apr 1, 2019

I have added this pull request to a triage collection of exit related issues for future reference.

This pull request has not had any activity in over six months. It isn't likely to get acted on due to this report.

Feel free to open a new issue if it comes up again, with new information and renewed interest.

Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants