Error out if unknown command

index.js

@@ -496,6 +496,12 @@ Command.prototype.parse = function(argv) {
     return this.executeSubCommand(argv, args, parsed.unknown);
   }
 
+  // Output unknown command error
+  if (args.length > 0) {
+    console.error('error: unknown command %s', args[0]);
+    this.outputHelp();
+  }
+
   return result;
 };
 
@@ -584,7 +590,9 @@ Command.prototype.executeSubCommand = function(argv, args, unknown) {
     } else if (err.code === 'EACCES') {
       console.error('error: %s(1) not executable. try chmod or run with root', bin);
     }
-    process.exit(1);
+    if (process.env.NODE_ENV !== 'test') {
+      process.exit(1);
+    }
   });
 
   // Store the reference to the child process

test/fixtures/cmd

@@ -0,0 +1,8 @@
+#!/usr/bin/env node
+
+var program = require('../../');
+
+program
+  .version('0.0.1')
+  .command('foo [name]', 'dummy command to test unknown command')
+  .parse(process.argv);

test/fixtures/cmd-foo

@@ -0,0 +1,2 @@
+#!/usr/bin/env node
+console.log('foo');

test/test.command.allowUnknownOption.js

@@ -24,7 +24,7 @@ program
   });
 program.parse('node test sub -m'.split(' '));
 
-stubError.callCount.should.equal(1);
+stubError.callCount.should.equal(2);
 stubExit.calledOnce.should.be.true();
 
 // command with `allowUnknownOption`
@@ -48,7 +48,7 @@ program
   });
 program.parse('node test sub2 -m'.split(' '));
 
-stubError.callCount.should.equal(0);
+stubError.callCount.should.equal(1);
 stubExit.calledOnce.should.be.false();
 
 

test/test.command.executableSubcommandUnknown.js

@@ -0,0 +1,14 @@
+var exec = require('child_process').exec
+  , path = require('path')
+  , should = require('should');
+
+var bin = path.join(__dirname, './fixtures/cmd')
+
+exec(bin + ' foo', function (error, stdout, stderr) {
+  stdout.should.equal('foo\n');
+});
+
+const unknownSubcmd = 'foo_invalid';
+exec(bin + ' ' + unknownSubcmd, function (error, stdout, stderr) {
+  stderr.should.equal('error: unknown command ' + unknownSubcmd + '\n');
+});

test/test.command.noConflict.js

@@ -7,7 +7,7 @@ sinon.stub(process.stdout, 'write');
 
 program
   .version('0.0.1')
-  .command('version')
+  .command('version', 'description')
   .action(function() {
     console.log('Version command invoked');
   });

test/test.known.command.js

@@ -0,0 +1,21 @@
+var program = require('../')
+  , sinon = require('sinon')
+  , should = require('should');
+
+sinon.stub(process, 'exit');
+sinon.stub(process.stdout, 'write');
+
+var stubError = sinon.stub(console, 'error');
+
+var cmd = 'my_command';
+
+program.command(cmd, 'description');
+
+program.parse(['node', 'test', cmd]);
+
+stubError.callCount.should.equal(0);
+var output = process.stdout.write.args;
+output.should.deepEqual([]);
+
+sinon.restore();
+

test/test.options.version.custom.js

@@ -3,7 +3,7 @@ var program = require('../')
 
 var capturedExitCode, capturedOutput, oldProcessExit, oldProcessStdoutWrite;
 
-program.version('0.0.1', '-r, --revision');
+program.version('0.0.1', '-r, --revision').description('description');
 
 ['-r', '--revision'].forEach(function (flag) {
   capturedExitCode = -1;

test/test.options.version.js

@@ -3,7 +3,7 @@ var program = require('../')
 
 var capturedExitCode, capturedOutput, oldProcessExit, oldProcessStdoutWrite;
 
-program.version('0.0.1');
+program.version('0.0.1').description('description');
 
 ['-V', '--version'].forEach(function (flag) {
   capturedExitCode = -1;

test/test.unknown.command.js

@@ -0,0 +1,19 @@
+var program = require('../')
+  , sinon = require('sinon')
+  , should = require('should');
+
+sinon.stub(process, 'exit');
+sinon.stub(process.stdout, 'write');
+
+var stubError = sinon.stub(console, 'error');
+
+var cmd = 'my_command', invalidCmd = 'invalid_command';
+
+program.command(cmd, 'description');
+
+program.parse(['node', 'test', invalidCmd]);
+
+stubError.callCount.should.equal(1);
+
+sinon.restore();
+