Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure code and introduce morre thorough testing #83

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Restructure code and introduce morre thorough testing #83

wants to merge 13 commits into from
+1,333 −1,076

Commits on Sep 1, 2019

  1. Extracts command setup code to util.js file

    @deiga
    deiga committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    867cdf9 View commit details
    Browse the repository at this point in the history

  2. Corrects some crammar and casing

    @deiga
    deiga committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    ab5ef82 View commit details
    Browse the repository at this point in the history

  3. Removes complex image handling 

    terminal-notifier only accepts `-appIcon`
    @deiga
    deiga committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    cb19e98 View commit details
    Browse the repository at this point in the history

  4. Removes unnecessary assignment

    @deiga
    deiga committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    7877740 View commit details
    Browse the repository at this point in the history

  5. Avoid unnecessary re-assignment

    @deiga
    deiga committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    c17255c View commit details
    Browse the repository at this point in the history

  6. Restructure main function into smaller parts

    @deiga
    deiga committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    4e6090e View commit details
    Browse the repository at this point in the history

  7. Refator into smaller functions

    @deiga
    deiga committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    5a7613f View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2019

  1. Re-adds node 4 to Travis tests

    @deiga
    deiga committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    13fb4fd View commit details
    Browse the repository at this point in the history

  2. Updates engines to reflect correct compatibility

    @deiga
    deiga committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    b584672 View commit details
    Browse the repository at this point in the history

  3. Adds formatting configurations 

    Includes prettier support
    @deiga
    deiga committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    b5d5eef View commit details
    Browse the repository at this point in the history

  4. Fixes node 6 incompatibility

    @deiga
    deiga committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    8da0e90 View commit details
    Browse the repository at this point in the history

  5. Change order of functions

    @deiga
    deiga committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    ebe7e99 View commit details
    Browse the repository at this point in the history

  6. Extracts command building to module

    @deiga
    deiga committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    4525499 View commit details
    Browse the repository at this point in the history