feat(mesh): add mesh support to tkestack #1063
Conversation
|
@leoryu please help review and show you comments, thanks |
| @@ -73,7 +74,7 @@ require ( | |||
| golang.org/x/crypto v0.0.0-20200414173820-0848c9571904 | |||
| golang.org/x/net v0.0.0-20200324143707-d3edc9973b7e | |||
| golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d | |||
| google.golang.org/grpc v1.26.0 | |||
| google.golang.org/grpc v1.28.1 | |||
There was a problem hiding this comment.
Why change grpc verstion to 1.28.1, and redirect version to 1.26 in the head?
There was a problem hiding this comment.
Because of the etcd bug,see this:
etcd-io/etcd#11931
There was a problem hiding this comment.
Please try to donwgrade grpc to v1.26 which is more stable version.
There was a problem hiding this comment.
go.mod doesn't support inherit for replace option, that cause third party developer have to update go.mod to have this replace change, @foshantiger could you please take more time to find a better solution here?
There was a problem hiding this comment.
Haven't find a solution better than replace yet, I will update the development doc as a notice for that.
pkg/mesh/apiserver/install.go
Outdated
| * Tencent is pleased to support the open source community by making TKEStack | ||
| * available. | ||
| * | ||
| * Copyright (C) 2012-2019 Tencent. All Rights Reserved. |
There was a problem hiding this comment.
Please check files you created, date shoud be 2021, not 2019 or 2020.
pkg/mesh/external/tcmesh/cache.go
Outdated
| c.clusterToMainClustersMap) | ||
| } | ||
|
|
||
| //func (c *Cacher) preSync() { |
|
|
||
| Clusters []*ClusterConfig `json:"clusters"` | ||
|
|
||
| // may remove 存量 1.3.6, DO NOT USE ANYMORE |
|
|
||
| // ProxyConfiguration defines config options for Proxy | ||
| type ProxyConfiguration struct { | ||
| Image string `json:"image,omitempty" protobuf:"bytes,1,opt,name=image"` |
There was a problem hiding this comment.
Some fileds have protobuf tag, but some fileds don't. Why?
There was a problem hiding this comment.
Legacy code, I will delete the protobuf tags.
|
|
||
| MornitorReportAddress string `json:"mornitor_report_address,omitempty"` | ||
|
|
||
| // 敏感信息 |
pkg/mesh/services/mesh/service.go
Outdated
| return rets, errs | ||
| } | ||
|
|
||
| /*func (m *meshClusterService) GetService( |
There was a problem hiding this comment.
Please check this dead func.
pkg/mesh/services/monitor/service.go
Outdated
| return result, nil | ||
| } | ||
|
|
||
| //func inApp(serviceNames []string, name string) bool { |
There was a problem hiding this comment.
Please check theses dead funcs.
|
lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Feature: add mesh support refer to proposal #1008
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: