Check that last ≥ first in parseCPURange

tklauser · May 2, 2024 · 0cd81e3 · 0cd81e3
1 parent dae747a
commit 0cd81e3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/numcpus_linux.go b/numcpus_linux.go
@@ -15,6 +15,7 @@
 package numcpus
 
 import (
+	"fmt"
 	"os"
 	"path/filepath"
 	"strconv"
@@ -60,6 +61,9 @@ func parseCPURange(cpus string) (int, error) {
 		if err != nil {
 			return 0, err
 		}
+		if last < first {
+			return 0, fmt.Errorf("last CPU in range (%d) less than first (%d)", last, first)
+		}
 		n += int(last - first + 1)
 	}
 	return n, nil

diff --git a/numcpus_linux_test.go b/numcpus_linux_test.go
@@ -25,6 +25,7 @@ func TestParseCPURange(t *testing.T) {
 		{str: "", n: 0},
 		{str: "0", n: 1},
 		{str: "0-1", n: 2},
+		{str: "1-1", n: 1},
 		{str: "0-7", n: 8},
 		{str: "1-7", n: 7},
 		{str: "1-15", n: 15},
@@ -37,6 +38,7 @@ func TestParseCPURange(t *testing.T) {
 		{str: "0-", n: 0, wantErr: true},
 		{str: "0-,1", n: 0, wantErr: true},
 		{str: "0,-3,5", n: 0, wantErr: true},
+		{str: "0,5-3", n: 0, wantErr: true},
 	}
 
 	for _, tc := range testCases {