Javacc4 config input file #259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 20, 2019 07:54
Rename the package names from tlatk to tla2sany and import the packages like they are imported in the file tlatools/src/tla2sany/Configuration.java. Note: When generating a parser from config.jj these imports are copied to the two files Configuration.java and ConfigurationTokenManager.java. The package name will be copied to all 7 files. This changes are non-functional. [Refactor][SANY]
Insert the code from Configuration.java into config.jj. * insert two static members errors and input * update the load() method * indent the load() and displayDefinitions() by two whitespaces Note: When generating a parser from config.jj this code will be copied to Configuration.java. This changes are non-functional. [Refactor][SANY]
Add throws AbortException to three methods that also have it in Configuration.java. Note: When generating a parser from config.jj the code for that methods is generated and inserted into Configuration.java This patch is non-functional. [Refactor][SANY]
Update the actions of the OpBuiltin() method, which represents the non-terminal OpBuiltin, that they match the method of the same name in Configuration.java. This patch is non-functional. [Refactor][SANY]
These changes let the output of the generated code be indented the same way it is currently in Configuration.java. These changes are non-functional. [Refactor][SANY]
JavaCC can generate code for different source levels. TLATools uses "1.8" at the moment. These changes are non-functional. [Refactor][SANY]
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
lemmy
force-pushed
the
master
branch
2 times, most recently
from
7d873a8
to
6a3b541
Compare
|
#408 would be a good reason to continue work on this PR. |
lemmy
force-pushed
the
master
branch
2 times, most recently
from
bd71c07
to
0a543cc
Compare
|
Upon investigation the entire purpose of this parser is just to parse a large string encoding all the operator symbols of TLA+ and their precedence ranges, associativity, etc. during SANY initialization (see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset applies the code from Configuration.java to the input file config.jj which is used to generate a fresh parser.
Only config.jj is changed in this patchset, so nothing can break.
A generated parser by JavaCC V4.0 from this config.jj has still differences to the currently used code,
but they are either trivial or unmodifiable by editing config.jj.
This is the diffstat of a patch from the current Configuration.java to a fresh one from JavaCC 4.0:
Configuration.java | 95 +++++++++++++++++++++--------------------------------
1 file changed, 38 insertions(+), 57 deletions(-)
Best regards.
P.S.: I fully understand and agree with your arguments and I'm not discouraged by your rejection.
Also I understand that my initial pull request #248 was too ambitious and could have been made more comprehensible.
Sadly I could not reproduce the failed JUnit-Tests you mentioned in #254, since I ran them also on my machine where they did not fail. I'm using:
openjdk version "1.8.0_191"
OpenJDK Runtime Environment (build 1.8.0_191-8u191-b12-2ubuntu0.18.04.1-b12)
OpenJDK 64-Bit Server VM (build 25.191-b12, mixed mode)