Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textfields [2 of 3]: refactor to share logic/components; make composable UI #3051

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

mimecuvalo
Copy link
Collaborator

This is the second of three textfield changes. This makes the textfields composable and refactors the hell out of them.

🎡 this is dangerous, I walk through textfields so watch your head rock 🎡

Change Type

  • minor β€” New feature

Release Notes

  • Refactor textfields be composable/swappable.

Copy link

vercel bot commented Mar 4, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
examples βœ… Ready (Inspect) Visit Preview May 20, 2024 10:52am
tldraw-docs βœ… Ready (Inspect) Visit Preview May 20, 2024 10:52am

@mimecuvalo mimecuvalo changed the title textfields: refactor to share logic/components; make composable UI textfields [2 of 3]: refactor to share logic/components; make composable UI Mar 4, 2024
@SomeHats
Copy link
Contributor

SomeHats commented Mar 5, 2024

So my overall take on this is that i like it & it's a step in the right direction. Using component overrides for shapes isn't something that we've done before (and should def be a tldraw, not editor thing) but that's not a reason to do it! i would be in favour of us making this change for now.

But! I don't think this is the ideal solution, or where we would land if we took a step back and looked at some of the wider context. these text changes are a small subset of a bigger problem, and one we hear from our community about again and again: customising our built-in shapes. we very regularly get requests that roughly look like "i want the interactions/structure of your shape, but i want to control rendering/styling myself, and maybe add some extra interactions on top".

To me, your emoji stuff is a subset of that problem, but I'm not sure the solution here would generalise well to the wider issue - i don't think we would want to add component overrides for every bit of a shape.

That said - I still think we should land this! It's 100% a step in the right direction and would give us a good place to iterate from. Although I do think this would be the perfect place to experiment with calling out a certain part of our API as experimental/unstable in docs. What do you think?

Base automatically changed from mime/textfields to main March 27, 2024 09:39
@huppy-bot huppy-bot bot added the minor Increment the minor version when merged label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants