New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using results for editor methods #3622
Draft
MitjaBezensek
wants to merge
9
commits into
main
Choose a base branch
from
mitja/return-results
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitjaBezensek
temporarily deployed
to
deploy-staging
April 26, 2024 13:28
— with
GitHub Actions
Inactive
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
MitjaBezensek
temporarily deployed
to
deploy-staging
April 26, 2024 13:33
— with
GitHub Actions
Inactive
MitjaBezensek
temporarily deployed
to
deploy-staging
April 26, 2024 13:36
— with
GitHub Actions
Inactive
MitjaBezensek
force-pushed
the
mitja/return-results
branch
from
April 26, 2024 13:37
afe1f12
to
de3dc5d
Compare
MitjaBezensek
temporarily deployed
to
deploy-staging
April 26, 2024 13:37
— with
GitHub Actions
Inactive
MitjaBezensek
temporarily deployed
to
deploy-staging
April 26, 2024 13:51
— with
GitHub Actions
Inactive
MitjaBezensek
temporarily deployed
to
deploy-staging
April 26, 2024 13:56
— with
GitHub Actions
Inactive
MitjaBezensek
temporarily deployed
to
deploy-staging
April 26, 2024 13:58
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example of how it would look like if we used
Result
type for our editor methods. ReworkedcreateShape
andcreateShapes
to use this.Change Type
sdk
— Changes the tldraw SDKdotcom
— Changes the tldraw.com web appdocs
— Changes to the documentation, examples, or templates.vs code
— Changes to the vscode plugininternal
— Does not affect user-facing stuffbugfix
— Bug fixfeature
— New featureimprovement
— Improving existing featureschore
— Updating dependencies, other boring stuffgalaxy brain
— Architectural changestests
— Changes to any test codetools
— Changes to infrastructure, CI, internal scripts, debugging tools, etc.dunno
— I don't knowTest Plan
Release Notes