Prevent pressing escape when editing document name to bubble up to the editor #3725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitjaBezensek
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
MitjaBezensek
force-pushed
the
mitja/stop-escape-propagation
branch
from
7f819e4
to
6ab14c7
Compare
MitjaBezensek
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
mimecuvalo
approved these changes
May 8, 2024
| // revert to original name instantly so that when we blur we don't | ||
| // trigger a save with the new one | ||
| setState((prev) => ({ ...prev, name: null })) | ||
| inputRef.current?.blur() | ||
| editor.getContainer().focus() |
There was a problem hiding this comment.
(i've been staring at focus too long). i don't think we need this line - looks like just doing stopEventPropagation will do the trick 👍
There was a problem hiding this comment.
I tried it, but then the second escape did not switch back to the select tool 🤷 Keyboard shortcuts worked, but escape didn't.
There was a problem hiding this comment.
ahh interesting interesting, didn't realize that! can you add a note that that's what the focus does? definitely we'll forget why we put that there later :)
|
lgtm! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents pressing escape to bubble to up to editor when editing document names. Prevents the current tool to change back to select tool.
Before
Pressing escape when editing the name stops the editing, but also switches from hand tool to select tool.
CleanShot.2024-05-08.at.15.37.33.mp4
After
We no longer switch to hand tool when we press escape the first time. The second time it still works though.
CleanShot.2024-05-08.at.15.51.09.mp4
@mimecuvalo happy to wait for your focus management PR to get merged, then update accordingly by using
editor.focus().Change Type
sdk— Changes the tldraw SDKdotcom— Changes the tldraw.com web appdocs— Changes to the documentation, examples, or templates.vs code— Changes to the vscode plugininternal— Does not affect user-facing stuffbugfix— Bug fixfeature— New featureimprovement— Improving existing featureschore— Updating dependencies, other boring stuffgalaxy brain— Architectural changestests— Changes to any test codetools— Changes to infrastructure, CI, internal scripts, debugging tools, etc.dunno— I don't knowTest Plan
Release Notes