Return undefined in the route method to tell that you ended the response yourself #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optionally just return for a route method which handles the response definitively (i. e. by calling this.response.end() or piping to the response). See http://stackoverflow.com/q/17073431/220060 for a use case.
|
This seems like a reasonable approach. Can you add some tests that make sure it works? We'll need to port this functionality over to the new router that's currently being worked on, and without tests, intricacies like this may get missed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://stackoverflow.com/q/17073431/220060 for a use case.
We had a similar use case. We need to stream a file with seek to implement pseudostreaming.
I also updated the documentation. Our team got very confused when they discovered that they could return a text instead of a template name. I read the source code and documented what's possible. Of course I added the new possibility to return undefined.