fix: prevent dev server crashing on malformed URI (fix vitejs#6300)

toSayNothing · Dec 29, 2021 · 776ebef · 776ebef
1 parent d856c4b
commit 776ebef
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/packages/vite/src/node/server/middlewares/transform.ts b/packages/vite/src/node/server/middlewares/transform.ts
@@ -99,10 +99,16 @@ export function transformMiddleware(
       }
     }
 
-    let url = decodeURI(removeTimestampQuery(req.url!)).replace(
-      NULL_BYTE_PLACEHOLDER,
-      '\0'
-    )
+    let url:string
+    try {
+      url = decodeURI(removeTimestampQuery(req.url!)).replace(
+        NULL_BYTE_PLACEHOLDER,
+        '\0'
+      )
+    } catch (e) {
+      res.end(`Bad request: ${e.message}`)
+      return
+    }
 
     const withoutQuery = cleanUrl(url)