Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary extension #6361

Conversation

Dunqing
Copy link

@Dunqing Dunqing commented Mar 28, 2024

The main reason is that these *.js files don't exist

@CLAassistant
Copy link

CLAassistant commented Mar 28, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added mod:infra Environment related issues and discussions mod:i18n Related to i18n mod:env app:electron Related to electron app mod:dev test Related to test cases labels Mar 28, 2024
Copy link

nx-cloud bot commented Mar 28, 2024

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.46%. Comparing base (e53744b) to head (3a7e9b1).
Report is 4 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6361      +/-   ##
==========================================
+ Coverage   62.38%   62.46%   +0.07%     
==========================================
  Files         510      510              
  Lines       23641    23643       +2     
  Branches     2231     2233       +2     
==========================================
+ Hits        14749    14768      +19     
+ Misses       8629     8612      -17     
  Partials      263      263              
Flag Coverage Δ
server-test 74.02% <ø> (+0.11%) ⬆️
unittest 38.72% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dunqing
Copy link
Author

Dunqing commented Mar 28, 2024

Since removing the extension caused many problems, I decided to close it.

Also, I'm very curious why the typecheck command is tsc -b tsconfig.json instead of tsc -noEmit Would this be faster?

@Dunqing Dunqing closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app mod:dev mod:env mod:i18n Related to i18n mod:infra Environment related issues and discussions test Related to test cases
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants