Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: self hosted register #6581

Draft
wants to merge 1 commit into
base: canary
Choose a base branch
from
Draft

fix: self hosted register #6581

wants to merge 1 commit into from
+59 −7

Conversation

darkskygit
Copy link
Member

No description provided.

@graphite-app Graphite App
Copy link

graphite-app bot commented Apr 16, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

@darkskygit Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @darkskygit and the rest of your teammates on Graphite Graphite

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 16, 2024 •
edited

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1c531d0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Apr 16, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.09%. Comparing base (19f8407) to head (1c531d0).

Additional details and impacted files 
@@             Coverage Diff             @@
##           canary    #6581       +/-   ##
===========================================
+ Coverage   39.52%   61.09%   +21.56%     
===========================================
  Files         408      574      +166     
  Lines        7868    26508    +18640     
  Branches     1323     2308      +985     
===========================================
+ Hits         3110    16194    +13084     
- Misses       4529    10050     +5521     
- Partials      229      264       +35
Flag Coverage Δ
server-test 70.19% <100.00%> (?)
unittest 39.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forehalo forehalo marked this pull request as draft April 16, 2024 09:24
EYHN
EYHN reviewed Apr 16, 2024
View reviewed changes
packages/backend/server/src/data/migrations/1713258139569-refresh-new-plan.ts
if (config.isSelfhosted && AFFINE_ADMIN_EMAIL) {
const user = ref.get(UserService, { strict: false });
const quota = ref.get(QuotaService, { strict: false });
const { id } = (await user.findUserByEmail(AFFINE_ADMIN_EMAIL)) || {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some selfhosted server have more than one user, we should let all users use this plan

@darkskygit darkskygit force-pushed the darksky/fix-self-hosted branch 2 times, most recently from 279c799 to cbc9203 Compare April 17, 2024 14:13
@Felitendo
Copy link

@forehalo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EYHN EYHN EYHN left review comments

@forehalo forehalo Awaiting requested review from forehalo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
app:server
Projects
AFFiNE Project
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@darkskygit @Felitendo @EYHN