Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): new dialog func to manage Modal #6676

Draft
wants to merge 3 commits into
base: canary
Choose a base branch
from

Conversation

CatsJuice
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Apr 23, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added mod:component app:electron Related to electron app labels Apr 23, 2024
Copy link

nx-cloud bot commented Apr 23, 2024

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 26.53061% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 60.90%. Comparing base (f1b0398) to head (8ca0f06).
Report is 4 commits behind head on canary.

Files Patch % Lines
...ckages/frontend/component/src/ui/dialog/dialog.tsx 20.68% 23 Missing ⚠️
...frontend/component/src/ui/dialog/dialog-center.tsx 12.50% 7 Missing ⚠️
...rontend/component/src/ui/dialog/confirm-dialog.tsx 16.66% 5 Missing ⚠️
packages/frontend/component/src/ui/dialog/state.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6676      +/-   ##
==========================================
- Coverage   61.04%   60.90%   -0.15%     
==========================================
  Files         574      579       +5     
  Lines       26572    26625      +53     
  Branches     2309     2316       +7     
==========================================
- Hits        16221    16216       -5     
- Misses      10087    10145      +58     
  Partials      264      264              
Flag Coverage Δ
server-test 70.01% <ø> (-0.12%) ⬇️
unittest 39.40% <26.53%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app mod:component
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

1 participant