Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more tracking events #6866

Merged
merged 1 commit into from May 13, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented May 10, 2024

Added most tracking events

what is missing:

  • still need a way to track events in blocksuite
  • some events may not 100% accurate of the one defined in the PRD

Copy link

graphite-app bot commented May 10, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added mod:infra Environment related issues and discussions app:core labels May 10, 2024
Copy link
Collaborator Author

pengx17 commented May 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@pengx17 pengx17 marked this pull request as ready for review May 10, 2024 08:25
@pengx17 pengx17 requested review from Brooooooklyn and EYHN May 10, 2024 08:25
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 66.54%. Comparing base (bd1733b) to head (3e23878).

Files Patch % Lines
...d/core/src/modules/workbench/services/workbench.ts 16.66% 5 Missing ⚠️
packages/common/infra/src/framework/core/event.ts 0.00% 1 Missing ⚠️
...re/src/components/affine/auth/user-plan-button.tsx 0.00% 1 Missing ⚠️
...d/core/src/modules/telemetry/services/telemetry.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6866      +/-   ##
==========================================
- Coverage   66.69%   66.54%   -0.16%     
==========================================
  Files         583      583              
  Lines       27173    27179       +6     
  Branches     2529     2527       -2     
==========================================
- Hits        18124    18087      -37     
- Misses       8781     8824      +43     
  Partials      268      268              
Flag Coverage Δ
server-test 77.12% <ø> (-0.20%) ⬇️
unittest 40.18% <11.11%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 05-10-feat_add_tracking_events_for_doc_created branch from 89d1316 to 5e271d5 Compare May 10, 2024 08:50
@github-actions github-actions bot added the mod:i18n Related to i18n label May 10, 2024
@pengx17 pengx17 force-pushed the 05-10-feat_add_tracking_events_for_doc_created branch from 5e271d5 to fdb4594 Compare May 10, 2024 10:29
@pengx17 pengx17 force-pushed the 05-10-feat_add_tracking_events_for_doc_created branch 2 times, most recently from f40c112 to a26f6f7 Compare May 10, 2024 11:13
@miladhatami1393
Copy link

Create

@pengx17 pengx17 changed the title feat: add tracking events for doc created feat: add more tracking events May 13, 2024
@pengx17 pengx17 force-pushed the 05-10-feat_add_tracking_events_for_doc_created branch from a26f6f7 to 4e4608c Compare May 13, 2024 03:15
@pengx17 pengx17 requested a review from EYHN May 13, 2024 03:15
Copy link

graphite-app bot commented May 13, 2024

Merge activity

Added most tracking events

what is missing:
- still need a way to track events in blocksuite
- some events may not 100% accurate of the one defined in the PRD
@pengx17 pengx17 force-pushed the 05-10-feat_add_tracking_events_for_doc_created branch from 4e4608c to 3e23878 Compare May 13, 2024 03:36
@graphite-app graphite-app bot merged commit 3e23878 into canary May 13, 2024
33 checks passed
@graphite-app graphite-app bot deleted the 05-10-feat_add_tracking_events_for_doc_created branch May 13, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:server mod:i18n Related to i18n mod:infra Environment related issues and discussions
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

4 participants