New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(blocks): resolve on file input dialog cancel #6950
fix(blocks): resolve on file input dialog cancel #6950
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that there are regressions on test cases. Any idea fixing it? Thanks!
e926fb4
to
cd1d80e
Compare
cd1d80e
to
440d51c
Compare
3bd265f
to
8bd63ed
Compare
8bd63ed
to
68bf8a4
Compare
68bf8a4
to
d589d11
Compare
hmmm.. deployment fails when I do rebase locally, while if I do it here it succeeds. |
d589d11
to
22aed06
Compare
Okay, no, it fails randomly. Is there a problem with the pull request? |
@shvixxl could be a flaky test introduced by this PR. You can refer to https://github.com/toeverything/blocksuite/blob/master/BUILDING.md#testing about testing. |
Close #6949.
add-images-button-fix.mov