fix(blocks): resolve on file input dialog cancel #6950
Merged
+41
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
shvixxl
changed the title
shvixxl
commented
May 6, 2024
doodlewind
reviewed
May 6, 2024
shvixxl
force-pushed
the
fix/blocks-resolve-on-file-input-dialog-cancel
branch
from
e926fb4
to
cd1d80e
Compare
shvixxl
force-pushed
the
fix/blocks-resolve-on-file-input-dialog-cancel
branch
from
cd1d80e
to
440d51c
Compare
shvixxl
force-pushed
the
fix/blocks-resolve-on-file-input-dialog-cancel
branch
2 times, most recently
from
3bd265f
to
8bd63ed
Compare
shvixxl
force-pushed
the
fix/blocks-resolve-on-file-input-dialog-cancel
branch
from
8bd63ed
to
68bf8a4
Compare
shvixxl
force-pushed
the
fix/blocks-resolve-on-file-input-dialog-cancel
branch
from
68bf8a4
to
d589d11
Compare
|
hmmm.. deployment fails when I do rebase locally, while if I do it here it succeeds. |
shvixxl
force-pushed
the
fix/blocks-resolve-on-file-input-dialog-cancel
branch
from
d589d11
to
22aed06
Compare
|
Okay, no, it fails randomly. Is there a problem with the pull request? |
|
@shvixxl could be a flaky test introduced by this PR. You can refer to https://github.com/toeverything/blocksuite/blob/master/BUILDING.md#testing about testing. |
Saul-Mirone
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6949.
add-images-button-fix.mov