feat: react adapters #6490
Closed
feat: react adapters #6490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
doodlewind
reviewed
Mar 19, 2024
| { | ||
| "name": "@blocksuite/react", | ||
| "version": "0.12.0", | ||
| "description": "Lit renderer for blocksuite store", |
There was a problem hiding this comment.
"Lit renderer?" 👀
I'm not sure if this package should belong to framework, since it may be used to wrap preset components like editors and fragments. /cc @Saul-Mirone
pengx17
force-pushed
the
feat/move-react-adapter
branch
from
346fa18
to
1a32351
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
pengx17
force-pushed
the
feat/move-react-adapter
branch
from
1a32351
to
9772dd0
Compare
pengx17
force-pushed
the
feat/move-react-adapter
branch
from
9772dd0
to
790ffd6
Compare
Saul-Mirone
approved these changes
Mar 22, 2024
Saul-Mirone
requested changes
Mar 22, 2024
|
Closing after discussion. A new react adapter will be introduced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom react wrapper, custom react renderer for lit and examples.
This PR migrated codes that are currently in AFFiNE codebase. We free like it is the time to move into blocksuite.
createReactComponentFromLitthat is similar tocreateComponentfrom@lit/react. This was added to mitigate issues that web components in blocksuite are often instantiated via creating web components & appending to dom directly in JS, described in [react] Property values are not available in the connectedCallback when using createComponent from @lit/react lit/lit#4435Kapture.2024-03-18.at.18.57.28.mp4